Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tool tip fixes #4129

Merged
merged 17 commits into from
Feb 7, 2023
Merged

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Jan 22, 2023

  • fix issues with mismatched htlm tags in the unit and pilot tool tips.
  • isolate the setting of fonts in in the unit and pilot tool tips, so that it would be easier to replace them with CSS.
  • fix issue with hard coded font colors in unit and pilot tool tips. use system defined ones instead.
  • fix issue with the unicode characters in the movement section of unit tool tip.
  • add in and <hr> around the pilot info in the board view tool tip, to make it it does not blend in with the unit info.
  • fix issue when determining good critial slots, it did not include missing ones. so it was diplaying double (good and bad), when missing.
  • only show the hits chance section in the attack tool tip when in the firing or physical phase. in the reporting phases only show who did it, since the hit info is no longer valid.

@kuronekochomusuke kuronekochomusuke marked this pull request as draft January 22, 2023 16:58
@kuronekochomusuke kuronekochomusuke added Bug GUI User Interface labels Jan 22, 2023
@kuronekochomusuke kuronekochomusuke marked this pull request as ready for review January 30, 2023 15:13
@rjhancock
Copy link
Collaborator

Overall doesn't look bad but please go through your changes and these files and adjust the variable names to be more descriptive.

@HammerGS
Copy link
Member

HammerGS commented Feb 7, 2023

Want to confirm all fixes are in place, then I'll merge.

@HammerGS HammerGS merged commit c0ba10d into MegaMek:master Feb 7, 2023
HammerGS added a commit that referenced this pull request Feb 7, 2023
@kuronekochomusuke kuronekochomusuke deleted the unitToolTipFixes branch March 3, 2023 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug GUI User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants