show movement for all entity types on unit tool tip #4130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kuronekochomusuke
commented
Jan 22, 2023
•
kuronekochomusuke
commented
- show movement mode for all entity types on unit tool tip. to make it easier to see what mode unit is in. most useful for units that can convert modes.
- correct issue of movement reduced bomb indicator incorrectly showing on LAMs.
kuronekochomusuke
added
Bug
(RFE) Enhancement
Windchild292
suggested changes
Jan 26, 2023
| @@ -1130,7 +1130,7 @@ public void clearBombChoices() { | |||
| @Override | |||
| public int reduceMPByBombLoad(int t) { | |||
| // bombs don't impact movement | |||
| return 0; | |||
There was a problem hiding this comment.
That goes against the comment, and doesn't appear related?
There was a problem hiding this comment.
the movement it not impacted so, so it should return the same value.
|
I'm just blind apparently, but does that cause issues with the actual movement given the very obvious comment above the changed LAM line. |
Windchild292
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.