add additional filters to advance search

[kuronekochomusuke]

Add a Combat Unit - Advance Search
Create Random Army - Advance Search

• add filter on entity type include / exclude
• add filter on Quirks include (And / OR) / exclude (And / OR)
• add filter on Weapon Quirks include (And / OR) / exclude (And / OR)
• add filter on Omni - Any, Yes, No
• add filter on Official - Any, Yes, No (MUL id != -1)
• add filter on Tonnage
• add filter on BV
• add filter on engine type
• add filter on clan engine
• add filter on source
• add filter on Transports
• add filter on Canon
• add filter on Unit Role
• add filter on Military
• add filter on Tank Turrets
• add filter on Lower Arms
• add filter on Hands
• add clear tab button - clears filters on current tab

• add unit count

• add out of
• add bv total

fixes #429
fixes #1380
fixes #2059
fixes #3216
fixes #1994

[HammerGS]

This is fantastic! Would there be any chance you could look into Engine Type, Quirks, and roles. I know the space in the dialog is really limited.

[kuronekochomusuke]

do you know if there are any units that are ETYPE_ARMLESS_MECH, ETYPE_FIGHTER_SQUADRON, ETYPE_TELEMISSILE type? if so what year. i could not find any those to test , so did not include them.

[kuronekochomusuke]

would the unit role go on the Alpha Strike tab?

[HammerGS]

do you know if there are any units that are ETYPE_ARMLESS_MECH, ETYPE_FIGHTER_SQUADRON, ETYPE_TELEMISSILE type? if so what year. i could not find any those to test , so did not include them.

None that I can think off. Squadrons and Telemissile would be something generated at the start of a game, or in game. I'm pretty sure armless gets added based of the damage to the unit.

would the unit role go on the Alpha Strike tab?

I think that would be a great spot for it.

I know this would be feature creep but if you could fit any more of these in it would be huge.
#1953

I also fully understand if that is beyond the scope of this PR.

[HammerGS]

I think this PR would address this - #1994?

[HammerGS]

I've been using this a lot and it works really well. But one thing I'm finding I'm doing more is starting with Unit Type then going to Base. I'm wondering if the tab order should be

• Unit Type
• Base
• Weapons
• Transports
• Quirks (since this is an option rule)

Any thoughts on this or customizable?

[HammerGS]

When this is done will they also search in MegaMekLab and MekHQ?

[kuronekochomusuke]

it looks like they will, since they use the advance search with the Alpha Strike tab. The other advance search does not have it.

[HammerGS]

Another suggestion. Would it be possible to have a clear button on each tab? Things like Unit Type can get pretty busy and sometimes you just want to reset the tab you're on. As opposed to backing all the way out.

[HammerGS]

I've opened a thread on the CGL forums to monitor for feedback and suggestions - https://bg.battletech.com/forums/megamek-games/advanced-search-improvements-coming-to-megamek/

So far a request for vehicle motive system, which I would be a big one.

[kuronekochomusuke]

can already search for motive modes on the Alpha Strike tab

[HammerGS]

Another request from the forums - A filter for units with Hands.

[kuronekochomusuke]

ready for review

[SJuliez]

OK great stuff, I have some comments. If I have commented on something that is clearly a legacy issue then give a comment on that.