Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add filters invalid and Failed to load equipment #4190

Merged
merged 2 commits into from
Feb 19, 2023
Merged

add filters invalid and Failed to load equipment #4190

merged 2 commits into from
Feb 19, 2023

Conversation

kuronekochomusuke
Copy link
Collaborator

  • add filter for invalid units
  • add filter for units that failed to load equipment

image

@kuronekochomusuke kuronekochomusuke added (RFE) Enhancement Requests for Enhancement, new features or implementations GUI User Interface Advanced Search RFE's related to improving the advanced search. labels Feb 18, 2023
Windchild292
Windchild292 suggested changes Feb 19, 2023
View reviewed changes
Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One spacing issue first

megamek/src/megamek/client/ui/swing/unitSelector/TWAdvancedSearchPanel.java Outdated Show resolved Hide resolved
@kuronekochomusuke @Windchild292
Update megamek/src/megamek/client/ui/swing/unitSelector/TWAdvancedSea…
6289a1f 
…rchPanel.java

Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
@Windchild292 Windchild292 merged commit 74c2ec4 into MegaMek:master Feb 19, 2023
@kuronekochomusuke kuronekochomusuke deleted the advancedSearchFilters branch March 3, 2023 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Windchild292 Windchild292 Windchild292 approved these changes

Assignees
No one assigned
Labels
Advanced Search RFE's related to improving the advanced search. GUI User Interface (RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuronekochomusuke @Windchild292