add filters tech level and tech base #4207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kuronekochomusuke
commented
Feb 25, 2023
kuronekochomusuke
commented
- add filter tech level
- add filter tech base
kuronekochomusuke
added
(RFE) Enhancement
HammerGS
approved these changes
Feb 26, 2023
|
Just curious: Do these two fields lead to different results from the fields we have in the unit selector main window? |
|
yes, it is different. The new Tech Level and Tech Base come from the values set in MegaMekLab and are shown on the summary tab of the mech preview in the add a combat unit search. Not sure where the Type: in the add a combat unit search comes from. |
|
would think the tech level should be the same, but they are not. could be these are old files that need to be updated, to have the tech level set correctly. Type: unofficial Tech Level: unofficial |
SJuliez
requested changes
Feb 27, 2023
megamek/src/megamek/client/ui/swing/unitSelector/TWAdvancedSearchPanel.java
Show resolved
Hide resolved
SJuliez
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.