Non-Meks in fire hexes #4758
Merged
Non-Meks in fire hexes #4758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAragua
approved these changes
Sep 8, 2023
NickAragua
reviewed
Sep 8, 2023
| @@ -19481,6 +19479,11 @@ private void resolveHarJelRepairs() { | |||
| * @param coordinates the coordinate location of the fire | |||
| */ | |||
| private void doFlamingDamage(final Entity entity, final Coords coordinates) { | |||
| // TO:AR p.41,p.43 | |||
| if (entity.tracksHeat() || entity.isDropShip()) { | |||
There was a problem hiding this comment.
Don't all dropships track heat?
There was a problem hiding this comment.
DS technically are not heat-tracking units, since they never use the Heat Scale (even though their weapons usage is limited by heat sink capacity). They are explicitly called out as unaffected by fire in the TO:AR fire rules, however.
There was a problem hiding this comment.
tracksHeat() is only true for Meks, ASF and Small Craft. Dropships have an override to return false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I understand TO:AR pg.41-43, all heat-tracking unit types (Mek, ASF, SC) are treated equally when standing in fire. All of those are not "All Other units" of pg.43 and don't get destroyed on a bad roll. They just suffer heat. This PR implements this.
Fixes #4734