-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 4754 vtols and cvs missing troop space bays #4760
Fix 4754 vtols and cvs missing troop space bays #4760
Conversation
…ed, or multiple blocks existed. Close MegaMek#4754
…s the NPE for MML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Original dev is aware that this needs fixing, but I need MML for other work, so I'd like to revert this change until the permanent fix is ready.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd initially read these functions as finding the start and end tags for a given block; instead they find the line index of the first text line, and the line index after the last text line, so e.g.:
<transporters>
troopspace:4.0
</transporters>
would give an index difference of 1
, and
<transporters>
</transporters>
would give a difference of 0
, rather than 1
as I had initially assumed. Mea culpa.
@@ -37,11 +41,7 @@ Hover | |||
</motion_type> | |||
|
|||
<transporters> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read this as a botched correction, not as an attempt to create two separate bays. Updating to a single bay with the new size produced entries that match the TRO.
@@ -41,8 +41,9 @@ Hover | |||
</motion_type> | |||
|
|||
<transporters> | |||
troopspace:8.0 | |||
BattleArmorHandles - troopers:-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only updated items to "OMNI" when I could confirm them via the TRO or sheet.
Sorry, I just spotted the merge conflict; if the new version is working, my reversion is no longer necessary. |
Fixes:
<transporters>
blocks that wouldn't have loaded correctly anyhow - only the first can be read.Testing:
close #4754