Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for natural aptitude piloting when doing physical attacks rolls #4862

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

kuronekochomusuke
Copy link
Collaborator

  • check for natural aptitude piloting when doing physical attacks rolls

fixes #4541

Copy link
Member

@NickAragua NickAragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing a couple of conditional blocks in this large if/else area where the attack isn't strictly a physical attack where NA:P would apply. Specifically, I'm looking at the "Telemissile" and "Lay Explosives". Let's double check those.

@NickAragua NickAragua merged commit 9d00faf into MegaMek:master Oct 31, 2023
4 checks passed
@kuronekochomusuke kuronekochomusuke deleted the issue4541 branch December 31, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Natural Aptitude: Piloting not applying to melee attack rolls
2 participants