Fixes for flame based infantry bugs #4867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in having heat mode.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
NickAragua
reviewed
Nov 3, 2023
|
Converting to draft pending implementing ruling about BMM heat option and non-Mech units. |
|
Curious if Princess will be able to use IDF with infantry/BA once this is done? |
NickAragua
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a number of related bugs with flame-based infantry weapons.
The most extensive change is the introduction of a subclass of Mounted that tracks both primary and secondary weapons and the movement of mode queries into Mounted. This was done because the flame-based effects are in play regardless of which weapon has the F attribute and the Mounted for the attack only had access to the weapon that is used to calculate the range.
For flame-based weapons that are capable of indirect fire, I added a new Indirect/Heat mode (and added indirect fire to the non-inferno mortar while I was at it).
InfantryHeatWeaponHandler needed significant revisions. As it is now, infantry would do heat but no damage to mechs if the BMM flamer option is checked (which should do heat + damage) and damage but no heat in all other situations. My changes have it doing heat + damage to all heat-tracking units (mechs, ASF, small craft) when the BMM option is checked, heat only to those units when not checked, and damage to all other units. If the weapon is in non-heat mode the InfantryWeaponHandler is used instead to do damage only.
Update: the heat+damage mode is now an unofficial option separate from BMM flamers.
Fixes #4793
Fixes #4213