Handle artillery strike against offboard unit that has disengaged. #4890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Report r = new Report(3158); | ||
| r.indent(); | ||
| r.subject = subjectId; | ||
| r.add(wtype.getName()); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
| Report r = new Report(3158); | ||
| r.indent(); | ||
| r.subject = subjectId; | ||
| r.add(wtype.getName()); |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null
I thought so too, but it looks like I only solved the issue with counter-battery fire, not firing on off-board fleeing targets in general -_-; |
NickAragua
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another issue with offboard artillery disengagement. I thought we had already fixed this one.
When the round lands, report the missing target instead of choking.
Fixes #4794.