-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement #4397, Internal Bomb Bay quirk, plus various fixes and improvements #4974
Implement #4397, Internal Bomb Bay quirk, plus various fixes and improvements #4974
Conversation
…disconnected players unit to gm
…ms display (pt. 1)
…for two bomb location types
…IBB reason message
This was intended for a new option in the top-level Exception handler dialog, but extraneous here.
in MechSearchFilter this should be removed since there is a class now.
|
I'm not sure that your last merge went well, you went from 60 to 125 files |
No, it definitely did not -_-; Increase in size is probably due to the rebase. |
I'm seeing strange files in this, like the userdirhelp I wrote looking as if it was new, a new unit, gradle.build changes (intentional?). I'm not sure what to do about it. Can you look into this? |
The gradle change I mentioned in the commit comment: it enables more stable debugging of AWT objects but can be pulled out if folks don't like it. The other stuff is likely due to rebasing and merging a change I'd made here on GitHub in the web UI back to the PR branch. If work takes a long time I like to rebase to the latest master state often so there's less work to do when my PR gets pulled (if it gets pulled). |
Well, looking back, I think you're right - something is screwed up. |
@NickAragua @Windchild292 @kuronekochomusuke @SJuliez @HammerGS Apologies for the churn. I'm closing this PR in favor of a cleaner one, without all the extra files and broken merges: |
This has some pretty big changes:
New gameplay features:
Changes/Additions
in service of reducing the number of classes that needed updates for IBB. This should also allow reducing the code in Aero considerably and moving ASF-only functionality into that class, if desired.
TO-DO / Not Yet Implemented
Testing
Note:
I updated the JVM options in build.gradle to use 4GB of RAM and disable AWT grabbing (source of a lot of freezing while debugging AWT windows). I can remove this if folks don't feel it's necessary for them.
Close #4397