Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add null check issue 5177 #5180

Merged
merged 4 commits into from
Feb 20, 2024
Merged

add null check issue 5177 #5180

merged 4 commits into from
Feb 20, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

  • add null check

fixes #5177

@kuronekochomusuke kuronekochomusuke changed the title add null check add null check issue 5177 Feb 19, 2024
Sleet01
Sleet01 approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@Sleet01 Sleet01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SJuliez
Copy link
Member

SJuliez commented Feb 19, 2024

Is it clear why game was null here?

@kuronekochomusuke
Copy link
Collaborator Author

kuronekochomusuke commented Feb 19, 2024 •
edited
Loading

the error in the log happens in the MULParser before a game is assigned

@SJuliez SJuliez merged commit df9aaa6 into MegaMek:master Feb 20, 2024
4 checks passed
@kuronekochomusuke kuronekochomusuke deleted the issue_5177 branch April 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SJuliez SJuliez SJuliez approved these changes

@Sleet01 Sleet01 Sleet01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kuronekochomusuke @SJuliez @Sleet01