Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Symbol Font Google Material Symbols #5319

Merged
merged 3 commits into from
Apr 20, 2024
Merged

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Apr 6, 2024

This adds a font with a ton of icons, google's Material Symbols together with its license (Apache 2.0). These icons seem useful e.g. for marking hexes or other uses. Because of the way thy are centered, they are less useful for inlining with other text. Also adds a method in FontHandler to get that symbol font without having to remember its name.

@SJuliez SJuliez requested a review from HammerGS April 20, 2024 08:30
@SJuliez
Copy link
Member Author

SJuliez commented Apr 20, 2024

@HammerGS You alright with this? It has a different license, Apache 2.0 (not OpenFont). Still seems ok to me.

@rjhancock
Copy link
Collaborator

Must provide appropriate credit but otherwise the licensing does not prevent its inclusion. The Apache License is actually more permissible than the OpenFont license in regards to fonts it seems.

# Conflicts:
#	megamek/src/megamek/client/ui/swing/util/FontHandler.java
Copy link

codecov bot commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 29.11%. Comparing base (0742934) to head (132122f).
Report is 93 commits behind head on master.

❗ Current head 132122f differs from pull request most recent head 6c47614. Consider uploading reports for the commit 6c47614 to get more accurate results

Files Patch % Lines
.../src/megamek/client/ui/swing/util/FontHandler.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5319      +/-   ##
============================================
+ Coverage     29.09%   29.11%   +0.02%     
- Complexity    13459    13473      +14     
============================================
  Files          2390     2389       -1     
  Lines        260774   260686      -88     
  Branches      46766    46747      -19     
============================================
+ Hits          75868    75900      +32     
+ Misses       181232   181121     -111     
+ Partials       3674     3665       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit 64a2c80 into MegaMek:master Apr 20, 2024
4 checks passed
@SJuliez SJuliez deleted the symbol-font branch April 20, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants