Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client settings for report font #5321

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

kuronekochomusuke
Copy link
Collaborator

@kuronekochomusuke kuronekochomusuke commented Apr 6, 2024

  1. add client settings for report font

image
image

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 4.34783% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 29.11%. Comparing base (b29a07c) to head (a879926).
Report is 1 commits behind head on master.

Files Patch % Lines
.../megamek/client/ui/swing/CommonSettingsDialog.java 0.00% 10 Missing ⚠️
megamek/src/megamek/common/Report.java 0.00% 7 Missing ⚠️
...ek/src/megamek/client/ui/swing/GUIPreferences.java 25.00% 3 Missing ⚠️
...src/megamek/client/ui/swing/MiniReportDisplay.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5321      +/-   ##
============================================
+ Coverage     29.09%   29.11%   +0.01%     
- Complexity    13458    13473      +15     
============================================
  Files          2389     2389              
  Lines        260723   260740      +17     
  Branches      46751    46752       +1     
============================================
+ Hits          75863    75904      +41     
+ Misses       181186   181171      -15     
+ Partials       3674     3665       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuronekochomusuke kuronekochomusuke added For New Dev Cycle This PR should be merged at the beginning of a dev cycle Reports Anything relating in game reporting labels Apr 6, 2024
@SJuliez SJuliez merged commit 530c505 into MegaMek:master Apr 20, 2024
5 of 6 checks passed
@kuronekochomusuke kuronekochomusuke deleted the reportFont branch April 20, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For New Dev Cycle This PR should be merged at the beginning of a dev cycle Reports Anything relating in game reporting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants