Fix reading player names from savegames #5322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5322 +/- ##
============================================
+ Coverage 29.10% 29.11% +0.01%
- Complexity 13458 13473 +15
============================================
Files 2389 2389
Lines 260682 260730 +48
Branches 46746 46754 +8
============================================
+ Hits 75860 75903 +43
- Misses 181148 181162 +14
+ Partials 3674 3665 -9 ☔ View full report in Codecov by Sentry. |
kuronekochomusuke
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading a game, the list of available player names from the savegame wasn't showing any names anymore. A format change to savegames added an node layer that wasnt parsed properly.