Add actionlistener for combobox in DialogOptionComponent #5369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronGullickson
added
the
For New Dev Cycle
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
megamek/src/megamek/client/ui/swing/DialogOptionListener.java
Dismissed
Show dismissed
Hide dismissed
megamek/src/megamek/client/ui/swing/DialogOptionListener.java
Dismissed
Show dismissed
Hide dismissed
megamek/src/megamek/client/ui/swing/DialogOptionListener.java
Dismissed
Show dismissed
Hide dismissed
megamek/src/megamek/client/ui/swing/DialogOptionComponent.java
Dismissed
Show dismissed
Hide dismissed
SJuliez
approved these changes
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for story arcs. The CreateCharacterDialog tracks how much XP has been used on skills and abilities as players make choices, but currently doesn't have any ability to track changes when they are made to JComboBoxes because there is no listener for those kinds of options. So, this PR adds a listener for those cases. I temporarily disable the listener when the
addValuemethod is called so that the listener is not triggered during initialization.This PR needs to be done at the same time as PRs in megameklab and MekHQ because they use the DialogOptionListener. Specifically:
For now, it should come after .19 is out.