-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MM's symbol font for some map indicators #5441
Conversation
I kind of wondered if changing the font for the movement text would impact the special characters. But when I did my testing, changing the font didn't seem to change my rendering for these indicators. At first glance the arrows appear visually noisy, but then again, I've been staring at the dots for a few months now. (When I originally had this idea my thought was to use arrows, but used directionally neutral circles to prototype to see how it worked and found that it felt clean ((but less intuitive))). |
Just my opinion, but I really like the arrows. I feel it makes it clear you can do something. Building of the coloring in the original. |
I initially made the no-turn (red open circles) hollow so that it was easily discernable from the green for red/green color deficiency. I think this work, because there will never be a green single arrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the StringDrawer improvements. :)
Is there any marker that could be added to distinguish "powered turn" vs "free turn" as well? Just got confirmation from a friend with such issues that the yellow and green remain hard to distinguish. Not sure what would fit without cluttering things up too much / being intuitively understandable, though (the arrows are absolutely perfect for "can turn" vs "can't turn"). For the final-position flag and excess movement text, I'd agree with having them both rendered so they always face north if possible (especially the latter, for obvious reasons). |
OK appreciate the comments.
|
Hmm. Technically I think the "free turn" indicator shouldn't show up at all in space, since you don't get free turns, but otherwise that looks great! |
@SJuliez Thank you for taking such great care of my baby! You've turned my very cool feature into an even cooler feature. Great work! I can't wait for people to love this! |
The dueFreeTurn() method did not consider if the unit is in space, this is done outside that method for path finding, but not for the flight path indicators. I couldnt see a reason why a unit in space should ever report that it could have a free turn and added that restriction. Seemed to work fine and now it doesnt show a free turn indicator in space. |
I noticed that on my selected move font the symbols for CF warning and flight path indicators were tofu and I couldnt find any font they worked with except the java logical serif. So this PR changes the symbols to some of the symbol font that is part of MM. This way they'll work for everyone and are independent from the move font. Additionally StringDrawer is upgraded to allow absolute Y centering without regard for ascent/descent which performs better for this use case (single symbols).
For the flight path symbols I thought I'd use arrows that are slightly more self-explanatory. Also the symbols are larger and less transparent so they show up well over complicated terrain or when zoomed out.