Modernize board validity checking code #5467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HammerGS
added a commit
that referenced
this pull request
May 16, 2024
+ PR #5475: Updating Project Dependencies + PR #5470: Allow plain look and feel border for Megamek Button + PR #5467: Modernize board validity checking code + Fix #5465: Bay ammo correction + PR #5454: Option to not automatically select a unit for whenever a turn for me comes around + Fix #5452: AS advanced search and rear weapon conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes board/hex/terrain validation to use a list of error Strings instead of a StringBuffer. This way the resulting error list can be formatted as needed (usually with a String.join) at the receiver instead of being preformatted. Line breaks are unnecessary. Also shortens code as a separate validity boolean is not needed.
The list would also lend itself to using a report line class with more functionality than the simple String report line if we wanted that.
Also corrects a board with errors.
Also compacts terrain checking a bit and imports the Terrains.* constants in Terrain to simplify code.