Fix 5483: Make various calls safer from NPE and ensure searchlight target on board #5485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the firing phase would throw an NPE if:
Root cause is twofold:
A) automatically selecting an off-board unit while checking to see if the selected friendly unit could use its Searchlight;
B) trying to get the hex location of units that don't have coords, in order to calculate if they are in the selected unit's arc.
This fix adds safety checks around these calls / tests to avoid this in the future, but per our Discord conversation, we
should definitely consider a non-null Coord value to represent "not on any board", especially if we will be adding more
simultaneous maps in the future.
Testing:
Close #5483