Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5489: NPE from BA AP Mount due to weapon linking to AP Mount equipment #5493

Merged

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented May 20, 2024

Problem in title.

Fix is only set atype if the linked equipment is not null and is an AmmoType.
This shouldn't negatively impact anything as other uses of atype include null check.

Testing:

  • Recreated and ran OP's save game in .20 code with and without fix.
  • Ran all three projects' unit tests

Close #5489

@Sleet01 Sleet01 merged commit 2412125 into MegaMek:master May 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java Error on dedicated servers possibly relating to alternate ammo
2 participants