-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steps towards SBF, player turns and stuff #5541
Steps towards SBF, player turns and stuff #5541
Conversation
…ts' into SBF-step-combine-reports-turn-processing # Conflicts: # megamek/src/megamek/common/strategicBattleSystems/SBFGame.java # megamek/src/megamek/server/SBFGameManager.java
…rocessing-NEW2 # Conflicts: # megamek/src/megamek/server/GameManager.java # megamek/src/megamek/server/SBFGameManager.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5541 +/- ##
=========================================
Coverage 29.28% 29.29%
- Complexity 13758 13771 +13
=========================================
Files 2443 2459 +16
Lines 262494 262554 +60
Branches 46974 46963 -11
=========================================
+ Hits 76875 76917 +42
- Misses 181766 181796 +30
+ Partials 3853 3841 -12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some naming questions, otherwise looks good (I didn't spend much time on SBF stuff as I believe it's still in flux).
This PR is a further small step towards SBF game handling. While having to look closely at our classes, I am using the opportunity to do some refactoring (or better: reorganization), making our existing classes smaller and seeing how to reuse them for SBF games.
This PR mainly
As in the last PRs for SBF I ask to leave in the loads of commented code in the SBF classes so I don't have to re-copy them later to see what's to be done. There are no intentional changes for standard games in here.
For review, there is a lot of code movement in here, so it's not quite as much as it looks like. Still, it's another big one. To test it I had two Princesses have a royal rumble and it seemed to work well.