-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude units by role on random generation, force generator table calculation updates #5572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for total model weight method. Replace call to total model weight method with overload.
…r of rating levels instead of hard coded value.
HammerGS
approved these changes
Jun 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work.
@SuperStucco This breaks tests in MekHQ and will need a companion PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial intention in this work was to change random selection parameters to allow excluding some units from random selection by role, to close #5564. Turns out the selection table math in the same place has a few kinks, so those fixes got rolled in.
Math fixes first:
There are a few bit of weirdness showing up, such as RAC/LAC field gun platoons being processed in 3058 even though they have much later introduction date (3062 for the former, 3068 for the latter). The LAC field gun models are not even present in the 3058.xml file. These models may be getting processed based on tech availability date rather than the keyed-in introduction date, but I'm treating that as out-of-scope for this PR and the calculations are successfully filtering them out.
These should not result in many changes for units like Mechs with few models per chassis. The largest changes will be seen with conventional infantry where there are regularly 10+ models per chassis, with the RATGen/force generator table numbers now more consistent with the availability numbers.