Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 5596: Fix range updates and projections in space #5598

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jun 19, 2024

A variety of different updates appear to have broken the part of our firing arc draw code that stops adding arcs for shorter-ranged weapons, specifically:

  • ASF weapons with variable range (e.g. ATMs)
  • Bay weapons

This fix returns that functionality so that only the in-range sections of a weapon or bay's arc will display, and the range will accurately reflect the selected ammo.

This patch also adds the ability to select variable-range ammo for enemy units and see their range bands without changing the loaded ammo on the viewed unit, for better turn planning by human players.

Testing:

  • Ran all 3 projects' existing unit tests
  • Tested extensively with ATM rounds on Aerospace units of various types
  • Also confirmed ground unit firing arc display has not been impacted

Close #5596

@Sleet01 Sleet01 requested a review from SJuliez June 19, 2024 10:51
Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one suggestion, although I should have thought of that for my own code... Not important, I can do that later, I'm constantly working in ClientGUI anyway

megamek/src/megamek/client/ui/swing/ClientGUI.java Outdated Show resolved Hide resolved
@SJuliez SJuliez merged commit 24a490d into MegaMek:master Jun 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.49.20] ASF in space can fire beyond weapon range
2 participants