Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MML 1532: Total Warfare Flamer should be unofficial #5622

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jun 22, 2024

"Total Warfare Flamer" is listed as a Standard CI support weapon, but has been replaced by the Pistol (Flamer) weapon.
The code comments state that this weapon should be marked unofficial but currently it is not.

Testing:

  • Tested weapons with various tech levels to confirm "Unofficial" setting is working correctly
  • Ran all three projects' unit tests

Close MegaMek/megameklab#1532

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.31%. Comparing base (a7d3d65) to head (e9b317f).
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #5622   +/-   ##
=========================================
  Coverage     29.31%   29.31%           
- Complexity    13787    13803   +16     
=========================================
  Files          2461     2461           
  Lines        262579   262664   +85     
  Branches      46976    47007   +31     
=========================================
+ Hits          76966    77010   +44     
- Misses       181746   181797   +51     
+ Partials       3867     3857   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sleet01 Sleet01 merged commit a734089 into MegaMek:master Jun 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Total Warfare Flamer Appears On Other Tech Levels Beyond Unofficial
2 participants