Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent NPE when OS launcher is being selected in weapons panel #5630

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

NickAragua
Copy link
Member

No idea what this "vAmmo" thing and how it's being set, but sometimes it's null. Fix #5629

@IllianiCBT
Copy link
Collaborator

I think it might be related to @Sleet01's ammo changes

@Sleet01
Copy link
Collaborator

Sleet01 commented Jun 25, 2024

I think it might be related to @Sleet01's ammo changes

As much as I like taking credit for breaking stuff, this looks like it's related to the Mounted* updates from the start of 0.49.20 dev. There are still some rough edges with older "is ammo valid / available" checks returning false or zero because they don't understand the new types quite yet.

@IllianiCBT IllianiCBT merged commit fc42ebf into MegaMek:master Jun 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE when selecting OS Weapons on BA
4 participants