Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6101: Fix selected ammo retrieval #6119

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 19, 2024

Fixes #6101
It doesn't even look like the problem was that the weapon was CI scale, more that it was out of ammo

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (c6d30f7) to head (f3afac0).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6119      +/-   ##
============================================
- Coverage     29.07%   29.07%   -0.01%     
+ Complexity    13972    13970       -2     
============================================
  Files          2601     2601              
  Lines        267447   267448       +1     
  Branches      47758    47757       -1     
============================================
- Hits          77767    77764       -3     
- Misses       185782   185788       +6     
+ Partials       3898     3896       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit d23fe81 into MegaMek:master Oct 21, 2024
6 checks passed
@SJuliez SJuliez deleted the small-sv-ci-wps-ammo branch October 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50] NPE when selecting CI-scale LRM on small SV in Weapons panel
3 participants