Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TroopSpace to InfantryCompartment #6181

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Nov 5, 2024

... as it is called in TM p239
merge together with counterpart PRs in MML and MHQ

@SJuliez SJuliez added the For New Dev Cycle This PR should be merged at the beginning of a dev cycle label Nov 5, 2024
@SJuliez SJuliez requested a review from HammerGS November 5, 2024 21:52
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.01%. Comparing base (a7bb1b4) to head (60a4fe0).
Report is 113 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6181      +/-   ##
============================================
- Coverage     29.17%   29.01%   -0.17%     
- Complexity    13971    13982      +11     
============================================
  Files          2628     2649      +21     
  Lines        266564   268128    +1564     
  Branches      47575    47723     +148     
============================================
+ Hits          77771    77798      +27     
- Misses       184910   186445    +1535     
- Partials       3883     3885       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@kuronekochomusuke
Copy link
Collaborator

kuronekochomusuke commented Nov 17, 2024

should the advanced search -> transports tab and mek summary also be updated with this?

image

@HammerGS HammerGS removed the For New Dev Cycle This PR should be merged at the beginning of a dev cycle label Nov 18, 2024
@SJuliez
Copy link
Member Author

SJuliez commented Nov 24, 2024

done

@HammerGS HammerGS merged commit 61d2def into MegaMek:master Nov 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants