Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pausing a Princess-only game #6186

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Nov 7, 2024

Allows pausing the game by using Ctrl-Shift-P and unpausing with Ctrl-Alt-P.

  • Both are normal keybinds that can be changed.
  • It only works if only bot units remain. This limitation is artificial and can be removed but that would have little use I guess.
  • This influences server packet handling so it is potentially dangerous; but as long as it isn't used I don't expect any errors from it
  • The effect is purely server-side, meaning that Princess will always finish whatever she is doing which may take a while; but if things move fast, the pause happens immediately
  • chat messages and log messages show pause/unpause happening

@SJuliez SJuliez added the For New Dev Cycle This PR should be merged at the beginning of a dev cycle label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.17%. Comparing base (a7bb1b4) to head (a58a77b).
Report is 69 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6186      +/-   ##
============================================
- Coverage     29.17%   29.17%   -0.01%     
+ Complexity    13971    13969       -2     
============================================
  Files          2628     2628              
  Lines        266564   266581      +17     
  Branches      47575    47569       -6     
============================================
- Hits          77771    77770       -1     
- Misses       184910   184928      +18     
  Partials       3883     3883              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HammerGS HammerGS added (RFE) Enhancement Requests for Enhancement, new features or implementations and removed For New Dev Cycle This PR should be merged at the beginning of a dev cycle labels Nov 17, 2024
@HammerGS
Copy link
Member

Fixes: RFE: Princess on Princess Action Pause #5965

@IllianiCBT
Copy link
Collaborator

Thank you so much, Julie. This is a great addition

@HammerGS HammerGS merged commit 0b2dda2 into MegaMek:master Nov 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(RFE) Enhancement Requests for Enhancement, new features or implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants