fix: stops bays from loading BA and protomek ammunition #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6220 +/- ##
=========================================
Coverage ? 29.01%
Complexity ? 13984
=========================================
Files ? 2649
Lines ? 268130
Branches ? 47724
=========================================
Hits ? 77801
Misses ? 186442
Partials ? 3887 ☔ View full report in Codecov by Sentry. |
Scoppio
commented
Nov 25, 2024
Comment on lines
+260
to
+263
| // A Bay should not load BA nor Protomek exclusive ammo/weapons | ||
| if (ammoType.hasFlag(F_BATTLEARMOR) || ammoType.hasFlag(F_PROTOMEK)) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
This is the only code newly added.
HammerGS
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an extra filter when loading munitions which discard BA/Protomek exclusive ammo types for the
BayMunitionsChoicePanel.All the other stuff changed is non-functional, just for better name or type expression and to remove some odities of "very-old-code (tm)"
Fixes: #6069