add tag for UnderWaterBridge #6250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kuronekochomusuke
commented
Dec 8, 2024
kuronekochomusuke
commented
- add tag for UnderWaterBridge
- these maps were probably built with incorrect bridges levels
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6250 +/- ##
=========================================
Coverage 28.99% 28.99%
- Complexity 13982 13984 +2
=========================================
Files 2652 2652
Lines 268296 268305 +9
Branches 47764 47768 +4
=========================================
+ Hits 77799 77804 +5
- Misses 186615 186617 +2
- Partials 3882 3884 +2 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Dec 8, 2024
SJuliez
reviewed
Dec 13, 2024
| if (hex.containsTerrain(WATER) | ||
| && hex.containsTerrain(BRIDGE) | ||
| && (hex.terrainLevel(BRIDGE_ELEV) < hex.terrainLevel(WATER))) { | ||
| underWaterBride++; |
There was a problem hiding this comment.
Underwater Bride? Whole new worlds :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.