Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech C Fusion Engines do not obey minimum weight rule #910

Closed
SaAnAlstad opened this issue May 14, 2021 · 4 comments · Fixed by MegaMek/megamek#3898
Closed

Tech C Fusion Engines do not obey minimum weight rule #910

SaAnAlstad opened this issue May 14, 2021 · 4 comments · Fixed by MegaMek/megamek#3898
Labels

Comments

@SaAnAlstad
Copy link

SaAnAlstad commented May 14, 2021

Environment

MekLab 0.49 (only stand-alone tested)
Win10
Java vendor AdoptOpenJDK
Java version 11.0.11

Description

In ML, fusion engines get cheaper the better their rating. For example, if the Engine Tech Rating is initially set to C, the overall cost of the vehicle will drop when it gets changed to D. Interestingly, when it then gets changed to E, the price doesn't change, but then a change to F has it drop again.

Files

Fusion Engine Rating - C
Fusion Engine Rating - D
Fusion Engine Rating - E
Fusion Engine Rating - F
megameklablog.txt

@SJuliez
Copy link
Member

SJuliez commented Jan 29, 2022

The scaling as such is in line with the rules, TM rules p.280 and 127. The cost scales with engine weight which goes down with tech rating. When two tech ratings have the same weight and cost, it's due to rounding. What's wrong according to my understanding of the rules is that tech C fusion engines will have an absolute minimum weight of 5t according to TM p.126 but MML doesnt set this. It doesnt affect any current units though.

@SJuliez SJuliez changed the title Fusion Engines mis-priced Tech C Fusion Engines do not obey minimum weight rule Jan 29, 2022
@neoancient
Copy link
Member

The minimum weight is enforced in the Engine class.

@HammerGS
Copy link
Member

Hi, I wanted to double check this one again based on this forum post.
https://bg.battletech.com/forums/non-combat-vehicles/pato-amphibious-plane-for-the-frontier/msg1865788/#msg1865788

When I checked our code I saw this.
image

But it references min weight as .5 tons not the pg 127 reference on Tech manual
image

But I could be misunderstanding the formulas.

@HammerGS HammerGS reopened this Sep 12, 2022
@neoancient
Copy link
Member

neoancient commented Sep 12, 2022

What's the issue? Lines 341-2 set the weight of D+ fusion engines to the calculated weight or 0.25t, whichever is greater. Lines 343-4 set the weight of fission and any other fusion engines to the greater of the calculated weight or 0.5t.

Edit: Oh, I see. It's supposed to be 5 and not 0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants