LGTM: Fixing the vast majority of open issues #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request fixes 12 alerts when merging 9b8f76c into 4849775 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 26 alerts when merging f3f7c02 into 4849775 - view on LGTM.com fixed alerts:
|
Windchild292
changed the title
|
I'm considering this no longer a draft given it fixes 26 of the 30 issues, and will open a PR shortly after this is merged to handle the final four issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all but four of the current LGTM issues for MML, including multiple resource leaks.
Once this is merged I'll fix the final four issues.
To Review:
Whitespace differences off, as I also fixed some whitespace problems.