Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #1045: Equipment filters #1055

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Mar 2, 2022

Fixes #1045
Requires MM #3474

Generally speaking, this adapts the equipment filtering somewhat to restore some missing equipment after the more extensive equipment table changes.

  • Adds an "Industrial" filter toggle to CV and SV (since they have no "Physical" filter). Industrial will show Backhoe, Dumper etc. Industrial eqp no longer appears in "Other"
  • Aero dont have access to industrial equipment except for the refueling drogue, which now appears in "Other"
  • On Meks, industrial eqp is shown under "Physical" to relieve the "Other" category a bit and since the game effects are often similar
  • Sponson turrets will appear again in "Other" for CV (SV handle them in the Structure tab)
  • CV chassis mods again appear as they should in "Other"
  • AMS and Laser AMS will now appear in "Other" in addition to "Energy" (Laser AMS) and "Ballistic" (AMS) since that doesnt hurt

# Conflicts:
#	megameklab/src/megameklab/ui/util/AbstractEquipmentDatabaseView.java
Copy link
Contributor

@Windchild292 Windchild292 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an odd bracket

Co-authored-by: Justin Bowen <39067288+Windchild292@users.noreply.github.com>
@SJuliez
Copy link
Member Author

SJuliez commented Mar 3, 2022

OK should be good.

@Windchild292 Windchild292 merged commit 068871b into MegaMek:master Mar 3, 2022
@SJuliez SJuliez deleted the PhysicalFilters branch April 12, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing CV equipment
2 participants