AS Crit View: Compact criticals after removing equipment #1282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fighter units use the crit slot system. Equipment is always shown in the crit view as if there were no gaps but removing e.g. equipment no. 2 in a location will currently leave the second slot empty. This leads to the right-click menu not working for some equipment after removing another equipment.
This PR compacts the crit slots on fighters when equipment is removed (deleted or removed by menu or dragged out) from a location, so that there don't remain empty crit slots between equipment. The change is not visible except for the popup menu now working more consistently.
Edit:
This proved a bit of a rabbit hole. So this PR now also: