Icon chooser in MML #1444
Merged
Icon chooser in MML #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # megameklab/src/megameklab/ui/generalUnit/StatusBar.java
# Conflicts: # megameklab/src/megameklab/ui/generalUnit/StatusBar.java
|
Oh man. Very nice! |
neoancient
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an icon selector to MML. This is accompanied by an MM change that enables storing a chosen icon in the unit file in base64 encoding. As with the recent fluff addition this is meant to be used for custom units so that they become self-contained and can be passed around or moved while keeping their icon/fluff intact. Also custom units need no more fiddling with the mechset (although it's still allowed of course).
This is not intended for canon units; the mechset should still be used.
The icon that is chosen via mechset (i.e. automatic) is shown in white (see tooltip). When an icon is chosen, either from file or from another unit in the cache, that icon is shown with a gold camo instead. Only a gold camo icon will be saved to the unit file.
To work properly this requires having the icons in MML. I'll add these in a separate PR so this one can even be reviewed.
Requires an MM PR and icon PR (tbd)