When printing from MUL, calculate BV from C3/Tag #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks fail because of missing MegaMek part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further builds on top of #1460 and additionally depends on MegaMek/megamek#5259.
To view the code changes just in this feature, select the last commit in this PR.
If #1460 is rejected, this PR could be refactored to be independent, but it does require the MegaMek part.
This PR makes it so that if printing from a MUL file, if the option to include pilot data is enabled, BV will be calculated with modifications from other units in the file, which includes C3 and TAG/semi-guided ammunition.
Testing:
A MUL file generated from the following force:
Produced the following prinout:
Fury_Command_Tank__C3M__etc-job_56.pdf