Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MML portion of fix for #1537: Disable Tech Rating chooser for non-BAR armor in SVs #1538

Conversation

Sleet01
Copy link
Collaborator

@Sleet01 Sleet01 commented Jun 26, 2024

MML side of fix for various NPEs and loading issues in #1537.

Disable the Armor Tech Rating chooser when non-BAR armor is chosen, to prevent confusion and also stop random fiddling with the chooser causing the Chassis Tech Rating (and thus weight) to fluctuate.

Testing:

  • Loaded previously-failing files after adjusting them manually, then confirmed re-saving them with the patched code fixed all issues.
  • Ran all three projects' unit test suites

Close #1537

@HammerGS HammerGS merged commit fbf45cd into MegaMek:master Jun 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Null point exception when exporting or trying to print Warship PDF
2 participants