Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'CHASSIS' key to some Thunderbolt MTF files #1564

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

juk0de
Copy link
Contributor

@juk0de juk0de commented Jul 20, 2024

This PR adds the string CHASSIS to the systemmanufacturer key of the following MTF files:

  • Thunderbolt_TDR-7M
  • Thunderbolt_TDR-7S
  • Thunderbolt_TDR-7SE
  • Thunderbolt_TDR-8M
  • Thunderbolt_TDR-9M
  • Thunderbolt_TDR-9NAIS
  • Thunderbolt_TDR-9Nr
  • Thunderbolt_TDR-9T

I encountered this issue while working on my MTF to JSON converter. Initially, I thought it was just an inconsistency, but these eight files are the only biped mech files missing the CHASSIS string. Therefore, I believe it is an ordinary bug, so I decided to fix it.

@IllianiCBT
Copy link
Collaborator

Congratulations on your first PR for this project!

@IllianiCBT IllianiCBT requested a review from HammerGS July 20, 2024 08:13
@IllianiCBT IllianiCBT added the Mek Concerns Meks label Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.52%. Comparing base (78b9c66) to head (1e50c58).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##             master   #1564   +/-   ##
========================================
  Coverage      0.52%   0.52%           
  Complexity       49      49           
========================================
  Files           265     265           
  Lines         30440   30440           
  Branches       5182    5182           
========================================
  Hits            160     160           
  Misses        30239   30239           
  Partials         41      41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS
Copy link
Member

I'll merge this, but for future reference all units file (BLK/MTF) are managed via MegaMek repo.

@HammerGS HammerGS merged commit 1ceb93b into MegaMek:master Jul 20, 2024
5 checks passed
@juk0de
Copy link
Contributor Author

juk0de commented Jul 20, 2024

I'll merge this, but for future reference all units file (BLK/MTF) are managed via MegaMek repo.

Understood 👍 Will create the next MTF related PR against MegaMek. But the MTF files are fundamentally identical between MegaMek and MegaMekLab, right?

@HammerGS
Copy link
Member

The master data repo is MegaMek and stays current. We only transfer the MM units to MML and MekHQ every few weeks and it's a manual process which is why we always use MM as the primary data repo.

@juk0de
Copy link
Contributor Author

juk0de commented Jul 20, 2024

Sounds complicated... Do I have to make another PR against MegaMek for these changes or are you going to transfer them manually?

@HammerGS
Copy link
Member

I’ve merged these and moved them the other way. In future make against MM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mek Concerns Meks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants