Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle for RS adjusted BV printing, and set default export filename #1582

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

pavelbraginskiy
Copy link
Collaborator

Closes #1581.

This PR contains two features:

  • When exporting from MUL to PDF, prefill the name of the pdf with the name of the mul file.
  • Add a checkbox to the print queue dialog when printing from MUL to adjust the BV displayed on the record sheet for force modifiers like TAG and C3. BV is always adjusted for pilot skill regardless of this checkbox.

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.65%. Comparing base (2164b26) to head (5a3bbba).
Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1582      +/-   ##
===========================================
- Coverage      0.65%   0.65%   -0.01%     
  Complexity       64      64              
===========================================
  Files           266     266              
  Lines         30511   30521      +10     
  Branches       5200    5203       +3     
===========================================
  Hits            201     201              
- Misses        30270   30280      +10     
  Partials         40      40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@HammerGS HammerGS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working

@HammerGS HammerGS merged commit 3d55fc7 into MegaMek:master Aug 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: Transfer MUL Name to PDF File Name
2 participants