Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FABRIC] crash with sodium and indium #7

Closed
glittermutt opened this issue Jan 15, 2024 · 12 comments
Closed

[FABRIC] crash with sodium and indium #7

glittermutt opened this issue Jan 15, 2024 · 12 comments

Comments

@glittermutt
Copy link

:(
crash report and log attached, i teleported to a stronghold and the game seemed to crash
https://mclo.gs/hbCYPxM
https://mclo.gs/ZrFvqpb

@MehVahdJukaar
Copy link
Owner

Oh noe

@MehVahdJukaar
Copy link
Owner

Omg why does sodium completely disregards vanilla biome colours providers. Seems like I have to add direct integration with it

@glittermutt
Copy link
Author

noo i hope u can figure it out!!!

@MehVahdJukaar
Copy link
Owner

omg and they made it an enum with no regard whatsoever to mods that miding add some of those and no way to extend it other than going nuclear with a super complicaated core mod i dont even know how to do

@MehVahdJukaar
Copy link
Owner

oh would you look at that theres a PR on sodium exactly for this. too bad its still not being merged for 3 weeks CaffeineMC/sodium#2222

@MehVahdJukaar
Copy link
Owner

I'll disable colormaps for now. polytone has no way of getting them to work without this. This is completely their issue for not only replacing vanilla system without inheriting from it as it should but also keeping it extremely locked up and non expandable with that enum. My hands are tied until that PR is merged

@glittermutt
Copy link
Author

i hope it gets merged 😭

@glittermutt
Copy link
Author

i updated polytone to the latest version, but it still crashed ^^; crash report and log attached
https://mclo.gs/jC3vVYT
https://mclo.gs/FSrd1on

@jellysquid3
Copy link

... Omg why does sodium completely disregards vanilla biome colours providers...
... This is completely their issue for not only replacing vanilla system without inheriting from it as it should...

Yes, Sodium prohibits the use of custom color resolvers, just like Minecraft does. We talked with a maintainer of Fabric API to consider adding an interface for mods to register custom color providers (which resulted in this pull request) and my hope is that it can be accepted soon, so that mods don't need to mixin into Minecraft to use custom color resolvers.

But to be clear, it's not really reasonable to expect that Sodium should anticipate (and support) every possible way that mods can mixin to vanilla code. It's even less reasonable to expect that we should then design all of our code to be easily hacked by other mods. This is what leads to a fragile and unmaintainable ecosystem. Modders should instead work with each other, and the platform maintainers, to create stable interfaces (like the linked pull request tries to solve.)

Anyways. Sorry your mod is broken with Sodium. We'll be publishing Sodium 0.5.6 some time within the next few days with a fix for the problem.

@Uranite
Copy link

Uranite commented Jan 28, 2024

Sodium 0.5.6 is out! 🎉

@glittermutt
Copy link
Author

hey, is sodium 0.5.6 going to be only for 1.20.3+ only?

@glittermutt
Copy link
Author

NEVERMIND IM A CRETIN

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants