That's a step forward implementing newest security requirements for Atlassian Connect #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Noticed there's a conflict, going to fix it tomorrow. |
bulinutza
approved these changes
Jul 16, 2021
|
@pawelniewie Thanks for this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
qsh_verifiedcan be now used to differentiate requests coming in from an iframe or via AP.request (qsh_verified will be false).BTW congrats @bulinutza on your promotion! 🍾
Also, tell me what plans do you have for AJA? I noticed you haven't been addressing security vulnerabilities found in Atlassian Connect architecture, does that mean you're moving away from this gem?
Or maybe you fixed them internally (as we did) without pushing to this repo?