qsh verification #40
Merged
qsh verification #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please update the version too. |
|
Yes, please update README and explain when you must verify qsh and in what cases you want to skip it. |
pawelniewie
reviewed
Jul 26, 2021
| @@ -81,12 +81,7 @@ def verify | |||
|
|
|||
| qsh = Digest::SHA256.hexdigest(qsh) | |||
|
|
|||
| unless data['qsh'] == qsh | |||
| log(:error, "QSH mismatch for client_key #{data['iss']} and addon_key #{addon_key}") | |||
There was a problem hiding this comment.
@bulinutza did this log line turned useful to you? Do you depend on it or can it be removed?
|
We never had verification fail because of qsh mismatch, so I'm ok with
removing it.
…On Mon, Jul 26, 2021 at 11:44 AM Pawel Niewiadomski < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In lib/atlassian-jwt-authentication/verify.rb
<#40 (comment)>
:
> @@ -81,12 +81,7 @@ def verify
qsh = Digest::SHA256.hexdigest(qsh)
- unless data['qsh'] == qsh
- log(:error, "QSH mismatch for client_key #{data['iss']} and addon_key #{addon_key}")
@bulinutza <https://github.com/bulinutza> did this log line turned useful
to you? Do you depend on it or can it be removed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMEGGAR76TJ4BXXSCFP2WDTZUVBJANCNFSM5A7QWJEA>
.
|
|
pawelniewie
approved these changes
Jul 27, 2021
|
@bulinutza you wanna take a look at this or should I merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
copying behaviour from atlassian-connect-express https://bitbucket.org/atlassian/atlassian-connect-express/src/58263a23be29b5603367f47341e984725b6a89b6/lib/middleware/authentication.js#lines-217
based on
https://community.developer.atlassian.com/t/action-required-atlassian-connect-vulnerability-allows-bypass-of-app-qsh-verification-via-context-jwts/47072
Probably I need to put into README explanation of what is qsh?