-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git options (commit, stage, and no git repository) #270
Conversation
I am pretty sure the workflow is failing because I added the extra flag |
@tomasohCHOM You need to update the workflow because a new flag was introduced, and that is the reason why the workflow is failing matrix:
framework:
[chi, gin, fiber, gorilla/mux, httprouter, standard-library, echo]
driver:
[mysql, postgres, sqlite, mongo, redis, none]
git:
[commit, stage, skip}
advanced:
[htmx, githubaction, websocket] - name: build templates
run: script -q /dev/null -c "go run main.go create -n ${{ matrix.framework }} -f ${{ matrix.framework}} -d ${{matrix.driver}} -g ${{matrix.git}} --advanced true --feature ${{ matrix.advanced }}" /dev/null Action will run the updated workflow on your PR. |
@Ujstor for sure, I'll do that right now! |
@Ujstor damn it seems that adding those three more flag options will exceed the 256 matrix size limit it seems. ![]() |
Hmm, interesting. I didn't know what a final limit is. Maybe we can constrain the maximum parallel jobs? Not sure if this would work, but let's give it a try. jobs:
framework_matrix:
strategy:
max-parallel: 128
matrix:
framework:
[chi, gin, fiber, gorilla/mux, httprouter, standard-library, echo]
driver:
[mysql, postgres, sqlite, mongo, redis, none]
advanced:
[htmx, githubaction, websocket]
git:
[commit, stage, skip] |
No luck with that unfortunately. It says in the GitHub documentation:
If we somehow can break it into multiple workflows, it might work. The flag that I added however does not contribute anything to the templates themselves, so if it is not 100% necessary, we could add a placeholder flag in - name: build templates
run: script -q /dev/null -c "go run main.go create -n ${{ matrix.framework }} -f ${{ matrix.framework}} -d ${{matrix.driver}} -g skip --advanced true --feature ${{ matrix.advanced }}" /dev/null |
Breaking it into two pieces was also on my mind. For now, your proposal is okay, but better change flag to commit, that way, we can catch bugs and also remove max-parallel. |
Got it, let me add that for now. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!! Will add it in just a second 👍 |
@tomasohCHOM Check also README.md file and add the --git commit flag in the appropriate places. |
@Ujstor Ok I added the |
I reran them manually, and now they are passing. More often than not, there is an issue with actions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
Problem/Feature
Please include a description of the problem or feature this PR is addressing.
Description of Changes:
git
flag to allow for the same options as in the interactive UIgit
flagChecklist