Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move handler_test.go to internal/server package #284

Merged
merged 3 commits into from
Jul 28, 2024

Conversation

eric-jacobson
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

Resolves #280

Description of Changes:

  • moved handler_test.go to internal/server package and renamed to routes_test.go
  • updated docs referring to handler_test.go in the previous location

Checklist

@eric-jacobson eric-jacobson marked this pull request as draft July 23, 2024 18:07
@eric-jacobson eric-jacobson marked this pull request as ready for review July 23, 2024 20:23
Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for solving the open issue. Only make test needs to be updated.

test:
	@echo "Testing..."
-	@go test ./tests -v
+	@go test ./... -v

@eric-jacobson
Copy link
Contributor Author

This looks good. Thanks for solving the open issue. Only make test needs to be updated.

test:
	@echo "Testing..."
-	@go test ./tests -v
+	@go test ./... -v

Good catch! Updated that as well as the makefile.md doc

Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ujstor Ujstor merged commit b5e0e3b into Melkeydev:main Jul 28, 2024
159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] Move handler_test.go into internal/server dir
2 participants