Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use slices.Contains instead of for loop to check if the provided db is in AllowedDBDrivers #293

Closed
wants to merge 1 commit into from

Conversation

sajjadvaezi
Copy link

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

Description of Changes:

  • use slices.Contains instead of for loop to check if the provided db is in AllowedDBDrivers

Checklist

@Ujstor
Copy link
Collaborator

Ujstor commented Aug 22, 2024

I am not sure what the purpose of the PR is. You changed only one file in the flags dir, and the tests are failing.

I will close it as incomplete.

@Ujstor Ujstor closed this Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants