Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tailwind should be called tailwind-install instead #326 #337

Merged
merged 3 commits into from
Nov 24, 2024

Conversation

pradytpk
Copy link
Contributor

@pradytpk pradytpk commented Nov 21, 2024

By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.

Problem/Feature

The make tailwind command should be renamed to make tailwind-install for better clarity. See issue #326 for details.

Description of Changes

  • Updated the Makefile template (makefile.tmpl) to replace tailwind with tailwind-install.

Checklist

Test Cases

  • Verified the updated Makefile includes the tailwind-install target.
  • Executed make tailwind-install to confirm it works as expected and outputs tailwindcss.
  • Executed make build to ensure the overall build process works without issues.

Copy link
Contributor

@LarsArtmann LarsArtmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Collaborator

@Ujstor Ujstor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ujstor Ujstor merged commit 946051e into Melkeydev:main Nov 24, 2024
195 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants