issue: Fix compilation with clang #1051
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sock-redirect implements read(), recv(), etc with intention to override them. However, some versions of glibc provide "fortified" calls. This is implemented by making regular symbols as inline wrappers on top of __read_chk() or similar. gcc allows to redefine such inline wrappers with specific attributes, but clang fails with an error. As a workaround for clang, rename glibc wrappers on the preprocessing stage. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
This fixes compilation error on a system with glibc-2.30 or higher. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Clang doesn't allow variable sized type not at the end of a struct claiming this is a GNU extension. Make a union instead of adding an array after the variable sized field. This fixes vmad compilation with clang. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
Suppress "dead nested assignment" warnings. Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
|
Can one of the admins verify this patch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix compilation errors and warnings with clang.
What
Fix compilation errors and warnings with clang.
Why ?
Compilation issues.
Change type
What kind of change does this PR introduce?
Check list