Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: Set MLX5_SHUT_UP_BF if VMA_BF=0 #1075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pasis
Copy link
Member

@pasis pasis commented May 9, 2024

Description

MLX5_SHUT_UP_BF forces rdma-core to create a single NC UAR instead of 16 BF registers. Since VMA_BF=0 is supposed to disable BlueFlame functionality, disable it in rdma-core as well.

What

Set MLX5_SHUT_UP_BF if VMA_BF=0

Why ?

Use NC UAR with disabled BlueFlame.

Change type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Tests
  • Other

Check list

  • Code follows the style de facto guidelines of this project
  • Comments have been inserted in hard to understand places
  • Documentation has been updated (if necessary)
  • Test has been added (if possible)

MLX5_SHUT_UP_BF forces rdma-core to create a single NC UAR instead of 16
BF registers. Since VMA_BF=0 is supposed to disable BlueFlame
functionality, disable it in rdma-core as well.

Signed-off-by: Dmytro Podgornyi <dmytrop@nvidia.com>
@swx-jenkins5
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants