chore: refactor NicDevice controller for better readability #82
+190
−252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almaslennikov
requested review from
e0ne,
adrianchiris,
ykulazhenkov and
heyvister1
also reduce code duplication Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
almaslennikov
force-pushed
the
nicdevice-controller-refactor
branch
from
e2f7ca4 to
f2f6a33
Compare
Pull Request Test Coverage Report for Build 13502548112Details
💛 - Coveralls |
ykulazhenkov
approved these changes
Feb 25, 2025
rollandf
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor all methods that execute in parallel to process a single object and introduce a
runInParallelwrapper for them (reduces code duplication and code nesting)add more debug logging