Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Validating webhook #32

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Add Validating webhook #32

merged 3 commits into from
Oct 2, 2023

Conversation

ykulazhenkov
Copy link
Collaborator

Add Validating webhook + switch deployment method to kustomize

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@coveralls
Copy link

coveralls commented Sep 25, 2023

Coverage Status

coverage: 72.058% (-4.2%) from 76.245% when pulling 4f86ec0 on ykulazhenkov:webhook into 11f148c on Mellanox:main.

@ykulazhenkov ykulazhenkov force-pushed the webhook branch 3 times, most recently from 4f86ec0 to 492d735 Compare September 27, 2023 12:13
Copy link
Collaborator

@almaslennikov almaslennikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deploy/crds/kustomization.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
api/v1alpha1/ippool_webhook.go Show resolved Hide resolved
@ykulazhenkov ykulazhenkov force-pushed the webhook branch 2 times, most recently from 0b2c1f2 to 8e160d1 Compare September 28, 2023 10:59
supported overlays:
- no-webhook - deploy without webhook
- certmanager - deploy with webhook to k8s cluster where
certmanager is available
- openshift - deploy with webhook to the Openshift cluster

Signed-off-by: Yury Kulazhenkov <ykulazhenkov@nvidia.com>
@ykulazhenkov ykulazhenkov merged commit c7a6c38 into Mellanox:main Oct 2, 2023
@ykulazhenkov ykulazhenkov deleted the webhook branch October 2, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants